Skip to content

Update of requests/controllers specs with invalid params for rails 7.0 #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Update of requests/controllers specs with invalid params for rails 7.0 #2585

merged 3 commits into from
Mar 28, 2022

Conversation

taketo1113
Copy link
Contributor

Fixes #2584

Fixed template of request spec and controller spec when #create and #update method with invalid params.
It only influence in rails ver over 7.0.0.

@taketo1113 taketo1113 changed the title Request spec rails7 Update of requests/controllers specs with invalid params for rails 7.0 Mar 27, 2022
@pirj
Copy link
Member

pirj commented Mar 27, 2022

Do you mind adding tests to support this change? Here and here.

@taketo1113
Copy link
Contributor Author

Do you mind adding tests to support this change? Here and here.

@pirj Added tests to check scaffold generator.

commit: a589cb1

@pirj pirj requested a review from JonRowe March 28, 2022 07:47
@JonRowe JonRowe merged commit 3818055 into rspec:main Mar 28, 2022
@JonRowe
Copy link
Member

JonRowe commented Mar 28, 2022

👍 thank you

@murilomendes
Copy link

Hello guys.

I'm still facing the error.
Any tip what I can to to take this change?

@JonRowe
Copy link
Member

JonRowe commented Mar 29, 2022

It has not yet been released, you will have to use the main branch as a Github dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail tests in generated request spec from scaffold in rails 7.0
4 participants